commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Makoto Sakaguchi (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (NET-621) SubnetUtils#SubnetInfo - Remove unnecessary accessors
Date Fri, 03 Mar 2017 06:22:45 GMT

     [ https://issues.apache.org/jira/browse/NET-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Makoto Sakaguchi updated NET-621:
---------------------------------
    Description: 
The below methods do not actually work.
- private int netmask()       \{ return netmask; \}
- private int network()       \{ return network; \}
- private int address()       \{ return address; \}
- private int broadcast()     \{ return broadcast; \}

So, I suggest to remove them.

  was:
The below methods do not actually work.

{code:title=SubnetUtils.java#SubnetInfo|borderStyle=solid }
private int netmask()       { return netmask; }
private int network()       { return network; }
private int address()       { return address; }
private int broadcast()     { return broadcast; }
{code}

So, I suggest to remove them.


> SubnetUtils#SubnetInfo - Remove unnecessary accessors
> -----------------------------------------------------
>
>                 Key: NET-621
>                 URL: https://issues.apache.org/jira/browse/NET-621
>             Project: Commons Net
>          Issue Type: Improvement
>            Reporter: Makoto Sakaguchi
>            Priority: Minor
>
> The below methods do not actually work.
> - private int netmask()       \{ return netmask; \}
> - private int network()       \{ return network; \}
> - private int address()       \{ return address; \}
> - private int broadcast()     \{ return broadcast; \}
> So, I suggest to remove them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message