commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (NET-619) SubnetUtils creates a binary netmask in a bad way
Date Wed, 01 Mar 2017 16:15:45 GMT

    [ https://issues.apache.org/jira/browse/NET-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890458#comment-15890458
] 

Sebb edited comment on NET-619 at 3/1/17 4:15 PM:
--------------------------------------------------

Whilst the original is not particularly clear, I'm not convinced that the suggested alternative
[1] is clearer.
However it does avoid an explicit loop.

IMO the problem in both cases is a lack of explanatory comments.

[1] https://github.com/apache/commons-net/pull/6


was (Author: sebb@apache.org):
Whilst the original is not particularly clear, I'm not convinced that the suggested alternative
is clearer.
However it does avoid an explicit loop.

IMO the problem in both cases is a lack of explanatory comments.

> SubnetUtils creates a binary netmask in a bad way
> -------------------------------------------------
>
>                 Key: NET-619
>                 URL: https://issues.apache.org/jira/browse/NET-619
>             Project: Commons Net
>          Issue Type: Improvement
>            Reporter: Makoto Sakaguchi
>            Priority: Minor
>
> SubnetUtils runs a for-loop to create a binary netmask.
> However, the way has been difficult to understand the program.
> I suggest to replace with a bit-shift, and it has been made a poll request on GitHub.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message