commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ric Emery (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IMAGING-199) All tEXt chunks are not returned from PngImageParser.getMetadata
Date Fri, 10 Mar 2017 00:11:37 GMT

    [ https://issues.apache.org/jira/browse/IMAGING-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904115#comment-15904115
] 

Ric Emery commented on IMAGING-199:
-----------------------------------

Submitted pull request in GitHub - https://github.com/apache/commons-imaging/pull/25 .

> All tEXt chunks are not returned from PngImageParser.getMetadata
> ----------------------------------------------------------------
>
>                 Key: IMAGING-199
>                 URL: https://issues.apache.org/jira/browse/IMAGING-199
>             Project: Commons Imaging
>          Issue Type: Bug
>          Components: Format: PNG
>            Reporter: Ric Emery
>            Priority: Minor
>              Labels: newbie
>
> According to the PNG spec - Section 4.2.3 - Textual Information -
> "Any number of text chunks can appear, and more than one with the same keyword is permissible.
"
> Unfortunately the PngImageParser.getMetadata method only supports a single tEXt chunk.
 The problem is in the following line:
>         final List<PngChunk> chunks = readChunks(byteSource, new ChunkType[] {
ChunkType.tEXt, ChunkType.zTXt, }, true);
> True is being passed for returnAfterFirst. I believe that false should be passed instead.
> I can submit a pull request if you agree.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message