commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebbASF <...@git.apache.org>
Subject [GitHub] commons-lang issue #231: Evaluate Architecure
Date Mon, 20 Mar 2017 10:48:48 GMT
Github user sebbASF commented on the issue:

    https://github.com/apache/commons-lang/pull/231
  
    Agreed it's not necessary to have the isXXX methods.
    However it makes the user code shorter and simpler.
    
    Currently the code is:
    
    ```
    Processor processor = ArchUtils.getProcessor();
    if (ProcessorArch.BIT_32.equals(processor.getProcessorArch())) {}
    if (ProcessorType.PPC.equals(processor.getProcessorType())) {}
    ```
    
    It would become:
    
    ```
    Processor processor = ArchUtils.getProcessor();
    if (processor.is32Bit()) {}
    if (processor.isPPC()) {}
    ```
    
    As well as being longer, in the first case one has to remember to whether to use ProcessorArch
or ProcessorType



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message