commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebbASF <...@git.apache.org>
Subject [GitHub] commons-lang pull request #231: Evaluate Architecure
Date Fri, 10 Mar 2017 11:23:05 GMT
Github user sebbASF commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/231#discussion_r105378662
  
    --- Diff: src/main/java/org/apache/commons/lang3/arch/Processor.java ---
    @@ -0,0 +1,30 @@
    +package org.apache.commons.lang3.arch;
    +
    +/**
    + *
    + */
    +public class Processor {
    +
    +    private String name;
    +    private ProcessorArch processorArch;
    +    private ProcessorType processorType;
    +
    --- End diff --
    
    I don't understand how the name field helps. 
    It's obviously necessary to be able to get the Processor object from the name, but once
you have the object, you know what the name is.
    So why do you think the name is necessary?
    
    The name field results in more objects being needed; if the name is not included then
all the PPC+64 systems (e.g.) can share the same object in the init code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message