commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebbASF <...@git.apache.org>
Subject [GitHub] commons-lang issue #231: Evaluate Architecure
Date Thu, 09 Mar 2017 10:27:51 GMT
Github user sebbASF commented on the issue:

    https://github.com/apache/commons-lang/pull/231
  
    If the code is not going to allow updates, then there is no need to use ConcurrentHashMap.
    If updates are allowed at run-time, there is the possibility that different results will
be obtained at different times.
    
    Alternatively, it's potentially possible to allow updates before first use of the data,
but disallow them later.
    
    This is the approach taken in Commons Validator
    
    http://commons.apache.org/proper/commons-validator/xref/org/apache/commons/validator/routines/DomainValidator.html
    
    This uses a flag to allow initial updates.
    Users have to get an instance before using the class; this resets the flag to stop further
changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message