commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kinow <...@git.apache.org>
Subject [GitHub] commons-lang issue #231: Evaluate Architecure
Date Tue, 07 Mar 2017 21:11:12 GMT
Github user kinow commented on the issue:

    https://github.com/apache/commons-lang/pull/231
  
    Excellent @Tomschi 
    
    I'm dropping a note to the mailing list to ask for feedback from crypto devs, as there
could be some synergy.
    
    I will play with the code at home, but one thing that I noticed is that it seems to contain
tabs... minor nit pick, but could you check checkstyle and make sure the code is not introducing
any warnings / errors there, please? That way it will be easier to merge the PR.
    
    Thanks!
    B


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message