Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Wed, 8 Feb 2017 19:19:41 +0000 (UTC)
From: "Stian Soiland-Reyes (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.13041457.1486581471000.31447.1486581581763@Atlassian.JIRA>
In-Reply-To: <JIRA.13041457.1486581471000@Atlassian.JIRA>
References: <JIRA.13041457.1486581471000@Atlassian.JIRA> <JIRA.13041457.1486581471289@jira-lw-us.apache.org>
Subject: [jira] [Commented] (COMMONSRDF-56) JSON-LD Literals wrongly compare
 equal
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 08 Feb 2017 19:19:48 -0000


    [ https://issues.apache.org/jira/browse/COMMONSRDF-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858415#comment-15858415 ] 

Stian Soiland-Reyes commented on COMMONSRDF-56:
-----------------------------------------------

Although the [fix has been proposed upstream|https://github.com/jsonld-java/jsonld-java/pull/190] I think we should avoid using .compareTo() at all and rather do this using direct calls on the getters.

> JSON-LD Literals wrongly compare equal
> --------------------------------------
>
>                 Key: COMMONSRDF-56
>                 URL: https://issues.apache.org/jira/browse/COMMONSRDF-56
>             Project: Apache Commons RDF
>          Issue Type: Bug
>          Components: jsonld-java
>            Reporter: Stian Soiland-Reyes
>             Fix For: 0.3.0
>
>
> There's a [bug in JSON-LD Java](https://github.com/jsonld-java/jsonld-java/pull/190) in {{Node.compareTo()}} for Literals, namely, they don't compare the values of the literal, language or datatype, which in Commons RDF can wrongly match a literal, say in dataset.stream() or in Literal.equals():
> {code}
>     JsonLdRDF rdf = new JsonLdRDF();
>     JsonLdLiteral lit1 = rdf.createLiteral("Hello");
>     JsonLdLiteral lit2 = rdf.createLiteral("Hello there");
>     assertNotEquals(lit1, lit2);
> {code}
> The above will fail because JsonLdLiteralImpl.equals does a short citcuit:
> {code}
>         if (obj instanceof JsonLdLiteral) {
>             final JsonLdLiteral other = (JsonLdLiteral) obj;
>             return asJsonLdNode().compareTo(other.asJsonLdNode()) == 0;
>         }
> {code}
> Similarly, using .contains or .stream matching a literal object backed by a JSON-LD Graph or Dataset will wrongly match any literal:
> {code}
>         JsonLdDataset dataset = rdf.createDataset();
>         JsonLdIRI s = rdf.createIRI("http://example.com/s");
>         JsonLdIRI p = rdf.createIRI("http://example.com/p");
>         JsonLdLiteral lit1 = rdf.createLiteral("Hello");
>         JsonLdLiteral lit2 = rdf.createLiteral("Other");
>         
>         dataset.add(null, s, p, lit1);
>         assertTrue(dataset.contains(Optional.empty(), s, p, lit2));
>         assertFalse(dataset.contains(Optional.empty(), s, p, lit2));
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)