Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Tue, 7 Feb 2017 15:41:41 +0000 (UTC)
From: "Sebb (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.13040594.1486378250000.17635.1486482101882@Atlassian.JIRA>
In-Reply-To: <JIRA.13040594.1486378250000@Atlassian.JIRA>
References: <JIRA.13040594.1486378250000@Atlassian.JIRA> <JIRA.13040594.1486378250407@jira-lw-us.apache.org>
Subject: [jira] [Resolved] (NET-610) FTPClient.mlistFile incorrectly handles
 MLST reply
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 07 Feb 2017 15:41:47 -0000


     [ https://issues.apache.org/jira/browse/NET-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved NET-610.
----------------------
       Resolution: Fixed
    Fix Version/s: 3.6

Author: sebb
Date: Tue Feb  7 15:33:35 2017
New Revision: 1782012

URL: http://svn.apache.org/viewvc?rev=1782012&view=rev
Log:
NET-610 FTPClient.mlistFile incorrectly handles MLST reply

Modified:
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPClient.java


> FTPClient.mlistFile incorrectly handles MLST reply
> --------------------------------------------------
>
>                 Key: NET-610
>                 URL: https://issues.apache.org/jira/browse/NET-610
>             Project: Commons Net
>          Issue Type: Bug
>          Components: FTP
>    Affects Versions: 3.5
>         Environment: using some FTP-server incorrectly releasing RFC 3659. For example xlight ftp server (https://www.xlightftpd.com/)
>            Reporter: Sergey Yanzin
>              Labels: easyfix, patch
>             Fix For: 3.6
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> By RFC 3659 server must start fact with space character. But some inaccurate realisations reply without starting space.
> But org.apache.commons.net.ftp.FTPClient.mlistFile() skips leading character even it is not a space:
>     public FTPFile mlistFile(String pathname) throws IOException
>     {
>         boolean success = FTPReply.isPositiveCompletion(sendCommand(FTPCmd.MLST, pathname));
>         if (success){
>             String entry = getReplyStrings()[1].substring(1); // skip leading space for parser
>             return MLSxEntryParser.parseEntry(entry);
>         } else {
>             return null;
>         }
>     }
> I think it is wrong. The method should throw exception, if first character is not a space. Or does not remove starting char (and should be some option responsible for that behaviour) if it is not a space.
> my workaround in overriden method:
>     public FTPFile mlistFile(String pathname) throws IOException {
>         final boolean success = FTPReply.isPositiveCompletion(sendCommand(FTPCmd.MLST, pathname));
>         if (success) {
>             final String reply = getReplyStrings()[1];
>             final String entry = reply.charAt(0) == ' ' ? reply.substring(1) : reply;
>             return MLSxEntryParser.parseEntry(entry);
>         } else {
>             return null;
>         }
>     }


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)