Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7CA00200C1A for ; Mon, 13 Feb 2017 14:09:48 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7B366160B60; Mon, 13 Feb 2017 13:09:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C5546160B4D for ; Mon, 13 Feb 2017 14:09:47 +0100 (CET) Received: (qmail 60343 invoked by uid 500); 13 Feb 2017 13:09:46 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 60224 invoked by uid 99); 13 Feb 2017 13:09:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Feb 2017 13:09:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 98CC4C12AB for ; Mon, 13 Feb 2017 13:09:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id GaveEo5zZD-y for ; Mon, 13 Feb 2017 13:09:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C00EC5FDD4 for ; Mon, 13 Feb 2017 13:09:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A8B4CE0657 for ; Mon, 13 Feb 2017 13:09:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D927721D72 for ; Mon, 13 Feb 2017 13:09:41 +0000 (UTC) Date: Mon, 13 Feb 2017 13:09:41 +0000 (UTC) From: "Sebb (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (NET-477) TFTP sendFile retry broken MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 13 Feb 2017 13:09:48 -0000 [ https://issues.apache.org/jira/browse/NET-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863636#comment-15863636 ] Sebb commented on NET-477: -------------------------- yes, see the dev list > TFTP sendFile retry broken > -------------------------- > > Key: NET-477 > URL: https://issues.apache.org/jira/browse/NET-477 > Project: Commons Net > Issue Type: Bug > Components: TFTP > Affects Versions: 3.1, 3.2 > Environment: Linux **** 3.2.0-29-generic #46-Ubuntu SMP Fri Jul 27 17:03:23 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux > java version "1.6.0_26" > Java(TM) SE Runtime Environment (build 1.6.0_26-b03) > Java HotSpot(TM) 64-Bit Server VM (build 20.1-b02, mixed mode) > Reporter: John Walton > Fix For: 3.6 > > > TFTPClient.java sendFile() method does not retry after initial timeout. > Between revisons 1088720 & 1229692 the 'continue' statements were changed to 'continue _sendPacket'. After the initial timeout of bufferedReceive() these cause the control to flow to the outer loop and never retry. If the control did flow accordingly, the retry would loop indefinitely since the timeouts variable is reset to zero each time as well. > I am using a workaround by calling bufferedSend(sent) just before continue, in place of the 'continue _sendPacket' statement. > It looks as if similar logic was applied to the receiveFile() method as well. > Revision:1229692 > Time:01/10/2012 01:14 PM > Author:sebb > Path:http://svn.apache.org/repos/asf/commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPClient.java > Message:NET-410 Apache Commons TFTP does not handle RFC 783 retransmits -- This message was sent by Atlassian JIRA (v6.3.15#6346)