commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mureinik <...@git.apache.org>
Subject [GitHub] commons-lang pull request #238: Validate's String.format without arguments
Date Sun, 19 Feb 2017 09:57:49 GMT
GitHub user mureinik opened a pull request:

    https://github.com/apache/commons-lang/pull/238

    Validate's String.format without arguments

    While calling `String.format("some string")` without any additional
    arguments is not technically wrong, it's redundant, as it just
    returns the same string.
    
    Removing these calls and just using the string instead both cleans up
    the code and offers a (very slight) performance gain.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mureinik/commons-lang string-format

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #238
    
----
commit 183c2522c5efce9f7d2e6f09e6fe872fd6ff0b8f
Author: Allon Mureinik <amureini@redhat.com>
Date:   2017-02-18T09:56:09Z

    Validate's String.format without arguments
    
    While calling String.format("some string") without any additional
    arguments is not technically wrong, it's redundant, as it just
    returns the same string.
    
    Removing these calls and just using the string instead both cleans up
    the code and offers a (very slight) performance gain.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message