commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COMMONSRDF-55) Stream of Jena quads use wrong IRI for default graph
Date Thu, 02 Feb 2017 10:29:51 GMT

    [ https://issues.apache.org/jira/browse/COMMONSRDF-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849768#comment-15849768
] 

ASF GitHub Bot commented on COMMONSRDF-55:
------------------------------------------

Github user afs commented on the issue:

    https://github.com/apache/commons-rdf/pull/32
  
    `defaultGraph` is explicit name of the default graph in Jena, `defaultGraphNode` is for
when the system is generating it, not for data.  There are methods for "is this the default
graph?" that abstract away from this detail. 
    
    The mark in the graph slot of the quad is anything to distinguish it - Jena uses a URI
although it is not properly "U"niversal - it is relative is the dataset. A quad is a triple
from a graph in a dataset.  Triples are universal.
    
    I guess I don't see the issue here: why is it not "Commons RDF marker for Quad/dft graph"
<=> "System X marker for Quad/dft graph" at the adapter boundary.


> Stream of Jena quads use wrong IRI for default graph
> ----------------------------------------------------
>
>                 Key: COMMONSRDF-55
>                 URL: https://issues.apache.org/jira/browse/COMMONSRDF-55
>             Project: Apache Commons RDF
>          Issue Type: Bug
>          Components: jena
>    Affects Versions: 0.3.0
>            Reporter: Stian Soiland-Reyes
>            Assignee: Stian Soiland-Reyes
>             Fix For: 1.0.0
>
>
> See https://travis-ci.org/apache/commons-rdf/builds/195548479
> {code}
> org.apache.commons.rdf.jena.DatasetJenaTest
> streamLanguageTagsCaseInsensitive(org.apache.commons.rdf.jena.DatasetJenaTest)  Time
elapsed: 0.012 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<<http://example.com/s1> <http://example.com/greeting>
"Hello"@EN-GB <urn:x-arq:DefaultGraph>.> but was:<<http://example.com/s1>
<http://example.com/greeting> "Hello"@en-GB .>
> {code}
> Jena uses the IRI `<urn:x-arq:DefaultGraph>` internally to represent the default
graph within datasets - we need to recognize that on the way out of a `JenaDatasetImpl.stream()`
and possibly in the `asQuad(JenaQuad)` converter and replace it with `Optional.empty()` so
the default graph appears the same across implementations.
> The `AbstractDatasetTest`  should be augmented to do more tests on the default graph,
including `.stream()`, `.iterate()`, `.contains()` and `.remove()`1.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message