commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COMMONSRDF-47) RDFSyntax should be interface, not enum
Date Thu, 09 Feb 2017 01:42:41 GMT

    [ https://issues.apache.org/jira/browse/COMMONSRDF-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858830#comment-15858830
] 

ASF GitHub Bot commented on COMMONSRDF-47:
------------------------------------------

Github user stain commented on the issue:

    https://github.com/apache/commons-rdf/pull/27
  
    Let's discuss the mutability etc. of the `RDFParser` factory separate on dev@commons -
that's a general thing which anyway should not affect this pull request on `RDFSyntax`.
    
    This pull requests tries to address [COMMONSRDF-47](https://issues.apache.org/jira/browse/COMMONSRDF-47)
which rightfully complains about `RDFSyntax` being an enum instead of interface.
    
    @ansell - would you change your `-1` (remember any committer has veto, and any ASF committer
is Commons committer :-) ) if I add the plural `RDFSyntax.mediaTypes()` and `RDFSyntax.fileExtensions()`
?


> RDFSyntax should be interface, not enum
> ---------------------------------------
>
>                 Key: COMMONSRDF-47
>                 URL: https://issues.apache.org/jira/browse/COMMONSRDF-47
>             Project: Apache Commons RDF
>          Issue Type: Bug
>          Components: api
>    Affects Versions: 0.2.0
>            Reporter: Stian Soiland-Reyes
>            Assignee: Stian Soiland-Reyes
>
> [~p_ansell] raises in [pull request 25|https://github.com/apache/incubator-commonsrdf/pull/25#discussion_r85231845]
> {quote}
> Using enum for RDFSyntax is a bad idea unless it overrides an interface and the interface
is used in method signatures instead of the enum. There are many other RDFSyntaxes, and enum
(without implementing an interface) is only suited to cases where the full set are known a
priori.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message