commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1110) Implement HashSetvBitSetTest using JMH
Date Sun, 12 Feb 2017 10:31:41 GMT

    [ https://issues.apache.org/jira/browse/LANG-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862726#comment-15862726
] 

ASF GitHub Bot commented on LANG-1110:
--------------------------------------

Github user C0rWin commented on the issue:

    https://github.com/apache/commons-lang/pull/182
  
    Hi Bruno,
    
    
    On Sun, Feb 12, 2017 at 6:35 AM, Bruno P. Kinoshita <
    notifications@github.com> wrote:
    
    > Hi @C0rWin <https://github.com/C0rWin>
    >
    > Some time ago I found this pull request and had to learn what was JMH :-)
    > added a comment on LANG-1110
    > <https://issues.apache.org/jira/browse/LANG-1110>, and today had time to
    > revisit the issue and take a look at the replies.
    >
    > So Commons CSV
    > <https://github.com/apache/commons-csv/blob/a7757849d3e9b2a37967ce208ab22f6d14567c98/pom.xml#L389>
    > and Commons RNG
    > <https://github.com/apache/commons-rng/tree/688f3611131e05a072d998edb93e13492c3ed256/commons-rng-jmh>
    > use JMH too. Both projects apply a similar approach, with the main
    > difference being that Commons RNG - maybe for being a multi-module project
    > - contains a jmh Maven module.
    >
    > However, the dependencies and plug-in execution are part of a benchmark
    > profile. Following the suggestions in LANG-1110
    > <https://issues.apache.org/jira/browse/LANG-1110>, would be nice if we:
    >
    >    - Used a similar approach, such as profile, class names, etc
    >    - Update jmh dependencies to the latest
    >    <http://search.maven.org/#search%7Cga%7C1%7Cjmh-core>
    >
    > I wanted to check with you before I opened a separate pull request. Would
    > you be willing to update this pull request again with these changes? If so,
    > just ping me and I'll reply here as soon as possible. Have plenty of time
    > to work on Open Source projects in the next two months :-)
    >
    
    I can update my pull request to align it with according to your request.
    
    Thanks,
        Artem Barger.



> Implement HashSetvBitSetTest using JMH
> --------------------------------------
>
>                 Key: LANG-1110
>                 URL: https://issues.apache.org/jira/browse/LANG-1110
>             Project: Commons Lang
>          Issue Type: Test
>          Components: lang.*
>            Reporter: Benedikt Ritter
>             Fix For: Patch Needed, 3.6
>
>         Attachments: HashSetvBitSetTest.java
>
>
> HashSetvBitSetTest currently writes to Std out, which is bad practice for unit tests.
Since HashSetvBitSetTest is really a performance test and not a unit test, we should reimplement
it using OpenJMH. The results could then be published on our website.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message