commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mureinik <...@git.apache.org>
Subject [GitHub] commons-lang pull request #240: Remove redundant semicolons from enums
Date Tue, 21 Feb 2017 16:45:37 GMT
Github user mureinik commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/240#discussion_r102256442
  
    --- Diff: src/test/java/org/apache/commons/lang3/EnumUtilsTest.java ---
    @@ -418,10 +418,10 @@ public void test_processBitVectors_longClass() {
         A00, A01, A02, A03, A04, A05, A06, A07, A08, A09, A10, A11, A12, A13, A14, A15,
         A16, A17, A18, A19, A20, A21, A22, A23, A24, A25, A26, A27, A28, A29, A30, A31,
         A32, A33, A34, A35, A36, A37, A38, A39, A40, A41, A42, A43, A44, A45, A46, A47,
    -    A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61, A62, A63;
    +    A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61, A62, A63
     }
     enum TooMany {
         A,B,C,D,E,F,G,H,I,J,K,L,M,N,O,P,Q,R,S,T,U,V,W,X,Y,Z,
         A1,B1,C1,D1,E1,F1,G1,H1,I1,J1,K1,L1,M1,N1,O1,P1,Q1,R1,S1,T1,U1,V1,W1,X1,Y1,Z1,
    -    A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2;
    +    A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2
     }
    --- End diff --
    
    I kept the style the code had. If we collectively decide that spaces would make the code
better, I'd gladly add them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message