commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kinow <...@git.apache.org>
Subject [GitHub] commons-lang issue #182: Add maven dependency for JMH framework.
Date Sun, 12 Feb 2017 04:35:59 GMT
Github user kinow commented on the issue:

    https://github.com/apache/commons-lang/pull/182
  
    Hi @C0rWin 
    
    Some time ago I found this pull request and had to learn what was JMH :-) added a comment
on [LANG-1110](https://issues.apache.org/jira/browse/LANG-1110), and today had time to revisit
the issue and take a look at the replies.
    
    So [Commons CSV](https://github.com/apache/commons-csv/blob/a7757849d3e9b2a37967ce208ab22f6d14567c98/pom.xml#L389)
and [Commons RNG](https://github.com/apache/commons-rng/tree/688f3611131e05a072d998edb93e13492c3ed256/commons-rng-jmh)
use JMH too. Both projects apply a similar approach, with the main difference being that Commons
RNG - maybe for being a multi-module project - contains a jmh Maven module.
    
    However, the dependencies and plug-in execution are part of a benchmark profile. Following
the suggestions in [LANG-1110](https://issues.apache.org/jira/browse/LANG-1110), would be
nice if we:
    
    * Used a similar approach, such as profile, class names, etc
    * Update [jmh dependencies to the latest](http://search.maven.org/#search%7Cga%7C1%7Cjmh-core)
    
    I wanted to check with you before I opened a separate pull request. Would you be willing
to update this pull request again with these changes? If so, just ping me and I'll reply here
as soon as possible. Have plenty of time to work on Open Source projects in the next two months
:-)
    
    Cheers
    Bruno


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message