Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C0024200C02 for ; Fri, 20 Jan 2017 13:15:31 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id BE81D160B48; Fri, 20 Jan 2017 12:15:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 148A5160B39 for ; Fri, 20 Jan 2017 13:15:30 +0100 (CET) Received: (qmail 16692 invoked by uid 500); 20 Jan 2017 12:15:30 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 16680 invoked by uid 99); 20 Jan 2017 12:15:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jan 2017 12:15:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C4709C0063 for ; Fri, 20 Jan 2017 12:15:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id P3wQYyJGDiu8 for ; Fri, 20 Jan 2017 12:15:29 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 952255FB5D for ; Fri, 20 Jan 2017 12:15:28 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id F2C57E023C for ; Fri, 20 Jan 2017 12:15:26 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 919F425285 for ; Fri, 20 Jan 2017 12:15:26 +0000 (UTC) Date: Fri, 20 Jan 2017 12:15:26 +0000 (UTC) From: "Rob Tompkins (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEXT-58) All uppercase methods? MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 20 Jan 2017 12:15:31 -0000 [ https://issues.apache.org/jira/browse/TEXT-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831625#comment-15831625 ] Rob Tompkins commented on TEXT-58: ---------------------------------- My plan is to attempt to get to this over the weekend as work has, of late, been particularly overwhelming. Hopefully from there we can move into attempting to release 1.0. > All uppercase methods? > ---------------------- > > Key: TEXT-58 > URL: https://issues.apache.org/jira/browse/TEXT-58 > Project: Commons Text > Issue Type: Improvement > Reporter: Gilles > Priority: Trivial > Labels: api, convention, standard > Fix For: 1.0 > > > Class {{o.a.c.text.translate.EntityArrays}} contains methods names with all uppercase letters (and underscores). > I understand that they create copies of _static_ constants (although even that is not true since they return arrays!), but are you sure you want to release a new component that does not follow the usual convention? > I understand these comes from LANG but isn't it the right time to fix the API? -- This message was sent by Atlassian JIRA (v6.3.4#6332)