Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 12 Jan 2017 14:18:52 +0000 (UTC)
From: "Gilles (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.13033699.1484136040000.2187.1484230732218@Atlassian.JIRA>
In-Reply-To: <JIRA.13033699.1484136040000@Atlassian.JIRA>
References: <JIRA.13033699.1484136040000@Atlassian.JIRA> <JIRA.13033699.1484136040405@arcas>
Subject: [jira] [Commented] (TEXT-58) All uppercase methods?
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 12 Jan 2017 14:18:54 -0000


    [ https://issues.apache.org/jira/browse/TEXT-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821092#comment-15821092 ] 

Gilles commented on TEXT-58:
----------------------------

Sorry, I was referring to [EntityArrays.java|https://github.com/apache/commons-text/blob/master/src/main/java/org/apache/commons/text/translate/EntityArrays.java].

bq. there's virtually no point in ever declaring a static final array.

It protects against assignment (but not change of elements).


> All uppercase methods?
> ----------------------
>
>                 Key: TEXT-58
>                 URL: https://issues.apache.org/jira/browse/TEXT-58
>             Project: Commons Text
>          Issue Type: Improvement
>            Reporter: Gilles
>            Priority: Trivial
>              Labels: api, convention, standard
>             Fix For: 1.0
>
>
> Class {{o.a.c.text.translate.EntityArrays}} contains methods names with all uppercase letters (and underscores).
> I understand that they create copies of _static_ constants (although even that is not true since they return arrays!), but are you sure you want to release a new component that does not follow the usual convention?
> I understand these comes from LANG but isn't it the right time to fix the API?


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)