Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 5 Jan 2017 14:30:58 +0000 (UTC)
From: "Andres Joy (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.13032270.1483626481000.650406.1483626658476@Atlassian.JIRA>
In-Reply-To: <JIRA.13032270.1483626481000@Atlassian.JIRA>
References: <JIRA.13032270.1483626481000@Atlassian.JIRA> <JIRA.13032270.1483626481077@arcas>
Subject: [jira] [Updated] (LANG-1309) Should EqualsBuilder.reflectionEquals
 return false if both values of a field is null?
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 05 Jan 2017 14:31:00 -0000


     [ https://issues.apache.org/jira/browse/LANG-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andres Joy updated LANG-1309:
-----------------------------
    Summary: Should EqualsBuilder.reflectionEquals return false if both values of a field is null?  (was: Should EqualsBuilder.reflectionEquals return false if both values of a field is false?)

> Should EqualsBuilder.reflectionEquals return false if both values of a field is null?
> -------------------------------------------------------------------------------------
>
>                 Key: LANG-1309
>                 URL: https://issues.apache.org/jira/browse/LANG-1309
>             Project: Commons Lang
>          Issue Type: Improvement
>            Reporter: Andres Joy
>            Priority: Minor
>
> EqualsBuilder.reflectionEquals return false if both values of the two objects on a field is null. Is this behavior intended? 
> Consider the following example:
> {code}class Person {
>   String name;
>   int age;
>   String phone = null;
>   ...
> }{code}
> And a main method:
> {code}Person p1 = new Person();
> p1.name = "Mike";
> p1.age = 30;
> Person p2 = new Person();
> p2.name = "Mike";
> p2.age = 30;
> assertTrue(EqualsBuilder.reflectionEquals(p1, p2));{code}
> This test won't pass because the assertion will fail. 
> Moreover, in this example, the objects we compare are actually equal(morally speaking) and the check should therefore return true. 
> What motivates the current behavior? 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)