commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Tompkins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEXT-58) All uppercase methods?
Date Sat, 14 Jan 2017 14:40:26 GMT

    [ https://issues.apache.org/jira/browse/TEXT-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822831#comment-15822831
] 

Rob Tompkins commented on TEXT-58:
----------------------------------

Definitely. I just don't see a reason for delivering an array with a fixed number of mutable
elements. Regardless, the topic at hand is: should we fix those constant style named factory
methods?

I'm not sure whether we stick with the exact API from lang for the sake of ease of migration
and fix such issues in 2.0 or fix the oddities such as this in 1.0. I think I'm going to pose
that on the M.L.

> All uppercase methods?
> ----------------------
>
>                 Key: TEXT-58
>                 URL: https://issues.apache.org/jira/browse/TEXT-58
>             Project: Commons Text
>          Issue Type: Improvement
>            Reporter: Gilles
>            Priority: Trivial
>              Labels: api, convention, standard
>             Fix For: 1.0
>
>
> Class {{o.a.c.text.translate.EntityArrays}} contains methods names with all uppercase
letters (and underscores).
> I understand that they create copies of _static_ constants (although even that is not
true since they return arrays!), but are you sure you want to release a new component that
does not follow the usual convention?
> I understand these comes from LANG but isn't it the right time to fix the API?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message