commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Tompkins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEXT-58) All uppercase methods?
Date Sat, 21 Jan 2017 15:53:26 GMT

    [ https://issues.apache.org/jira/browse/TEXT-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833038#comment-15833038
] 

Rob Tompkins commented on TEXT-58:
----------------------------------

I've found an interesting curiosity here. Bruno suggested that we simply use the newly created
UnmodifyableMaps to populate the {{lookupMap}} in the {{LookupTranslator}}. Unfortunately,
to be sufficiently general in the constructor, we would probably wish that it consume a {{Map<CharSequence,
CharSequence>}}. This causes issues in that the translate method only works on {{CharSequences}}
that have an implemented {{equals}} and {{hashCode}}. We thus, if we wish to remain sufficiently
general in the constructor, still need to build up a new {{Map<String, String>}} from
the input {{Map<CharSequence, CharSequence>}}.

I think we should still do this, but I wanted to bring the point up while I'm in here doing
the work. Furthermore, we need to consider https://issues.apache.org/jira/browse/LANG-882
as a reference about why we need do this.

> All uppercase methods?
> ----------------------
>
>                 Key: TEXT-58
>                 URL: https://issues.apache.org/jira/browse/TEXT-58
>             Project: Commons Text
>          Issue Type: Improvement
>            Reporter: Gilles
>            Assignee: Rob Tompkins
>            Priority: Trivial
>              Labels: api, convention, standard
>             Fix For: 1.0
>
>
> Class {{o.a.c.text.translate.EntityArrays}} contains methods names with all uppercase
letters (and underscores).
> I understand that they create copies of _static_ constants (although even that is not
true since they return arrays!), but are you sure you want to release a new component that
does not follow the usual convention?
> I understand these comes from LANG but isn't it the right time to fix the API?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message