commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEXT-58) All uppercase methods?
Date Thu, 12 Jan 2017 14:18:52 GMT

    [ https://issues.apache.org/jira/browse/TEXT-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821092#comment-15821092
] 

Gilles commented on TEXT-58:
----------------------------

Sorry, I was referring to [EntityArrays.java|https://github.com/apache/commons-text/blob/master/src/main/java/org/apache/commons/text/translate/EntityArrays.java].

bq. there's virtually no point in ever declaring a static final array.

It protects against assignment (but not change of elements).


> All uppercase methods?
> ----------------------
>
>                 Key: TEXT-58
>                 URL: https://issues.apache.org/jira/browse/TEXT-58
>             Project: Commons Text
>          Issue Type: Improvement
>            Reporter: Gilles
>            Priority: Trivial
>              Labels: api, convention, standard
>             Fix For: 1.0
>
>
> Class {{o.a.c.text.translate.EntityArrays}} contains methods names with all uppercase
letters (and underscores).
> I understand that they create copies of _static_ constants (although even that is not
true since they return arrays!), but are you sure you want to release a new component that
does not follow the usual convention?
> I understand these comes from LANG but isn't it the right time to fix the API?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message