commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1308) Move CvsTranslators out of StringEscapeUtils and make them DRY
Date Wed, 04 Jan 2017 23:41:58 GMT

    [ https://issues.apache.org/jira/browse/LANG-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799729#comment-15799729
] 

ASF GitHub Bot commented on LANG-1308:
--------------------------------------

Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/226
  
    Thanks for the pull request. 👍 
    
    StringEscapeUtils has been moved to commons-text and the commons-lang version will soon
be deprecated.
    
    It would be nice if you would create a pull request for https://github.com/apache/commons-text
instead.
    
    Thanks in advance!



> Move CvsTranslators out of StringEscapeUtils and make them DRY
> --------------------------------------------------------------
>
>                 Key: LANG-1308
>                 URL: https://issues.apache.org/jira/browse/LANG-1308
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*, lang.text.translate.*
>    Affects Versions: 3.5
>            Reporter: Jarosław Strzelecki
>            Priority: Minor
>
> CvsEscaper/CvsUnescaper are currently inner classes of StringEscapeUtils and it does
not seem like it is a proper place for them.
> Since they are package-private, they can be safely moved lang.text.translate package.
> Moreover it's possible make them more DRY by introducing SinlgePassTranslator as suggested
in TODO.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message