commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jarosław Strzelecki (JIRA) <j...@apache.org>
Subject [jira] [Updated] (LANG-1308) Move CvsTranslators out of StringEscapeUtils and make them DRY
Date Wed, 04 Jan 2017 23:26:58 GMT

     [ https://issues.apache.org/jira/browse/LANG-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jarosław Strzelecki updated LANG-1308:
--------------------------------------
    External issue URL: https://github.com/apache/commons-lang/pull/226
           Description: 
CvsEscaper/CvsUnescaper are currently inner classes of StringEscapeUtils and it does not seem
like it is a proper place for them.

Since they are package-private, they can be safely moved lang.text.translate package.

Moreover it's possible make them more DRY by introducing SinlgePassTranslator as suggested
in TODO.



  was:
CvsEscaper/CvsUnescaper are currently inner classes of StringEscapeUtils and I does not seem
like it is a proper place for them.

Since they are package-private, they can be safely moved lang.text.translate package.

Moreover it's possible make them more DRY by introducing SinlgePassTranslator as suggested
in TODO.




> Move CvsTranslators out of StringEscapeUtils and make them DRY
> --------------------------------------------------------------
>
>                 Key: LANG-1308
>                 URL: https://issues.apache.org/jira/browse/LANG-1308
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*, lang.text.translate.*
>    Affects Versions: 3.5
>            Reporter: Jarosław Strzelecki
>            Priority: Minor
>
> CvsEscaper/CvsUnescaper are currently inner classes of StringEscapeUtils and it does
not seem like it is a proper place for them.
> Since they are package-private, they can be safely moved lang.text.translate package.
> Moreover it's possible make them more DRY by introducing SinlgePassTranslator as suggested
in TODO.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message