commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1308) Move CvsTranslators out of StringEscapeUtils and make them DRY
Date Wed, 04 Jan 2017 23:22:58 GMT

    [ https://issues.apache.org/jira/browse/LANG-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799675#comment-15799675
] 

ASF GitHub Bot commented on LANG-1308:
--------------------------------------

GitHub user jarst opened a pull request:

    https://github.com/apache/commons-lang/pull/226

    [LANG-1308] Move CvsTranslators out of StringEscapeUtils and make them DRY

    CvsEscaper/CvsUnescaper are currently inner classes of StringEscapeUtils and it does not
seem like it is a proper place for them.
    Since they are package-private, they can be safely moved lang.text.translate package.
    Moreover it's possible make them more DRY by introducing SinlgePassTranslator as suggested
in TODO.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jarst/commons-lang feature/CvsTranslators

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #226
    
----
commit c806897b947d623a3d1c683698440de0dbe065e8
Author: Jaroslaw Strzelecki <jarst@users.noreply.github.com>
Date:   2017-01-04T21:24:58Z

    Move CSV translators to separate class

commit 8ca054ba54b37fe41f9faae6e1129012cc2021b1
Author: Jaroslaw Strzelecki <jarst@users.noreply.github.com>
Date:   2017-01-04T22:22:56Z

    Introduce SinglePassTranslator

commit 0ea5d6c5e73d0b79853954ba34327123f952019f
Author: Jaroslaw Strzelecki <jarst@users.noreply.github.com>
Date:   2017-01-04T22:35:31Z

    Make CSV translators extend SinglePassTranslator

commit 99073efdf33d0ece00ed4b5c2aa07b70ea5ae334
Author: Jaroslaw Strzelecki <jarst@users.noreply.github.com>
Date:   2017-01-04T22:47:44Z

    CSV translators - minor tweaks

----


> Move CvsTranslators out of StringEscapeUtils and make them DRY
> --------------------------------------------------------------
>
>                 Key: LANG-1308
>                 URL: https://issues.apache.org/jira/browse/LANG-1308
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*, lang.text.translate.*
>    Affects Versions: 3.5
>            Reporter: Jarosław Strzelecki
>            Priority: Minor
>
> CvsEscaper/CvsUnescaper are currently inner classes of StringEscapeUtils and I does not
seem like it is a proper place for them.
> Since they are package-private, they can be safely moved lang.text.translate package.
> Moreover it's possible make them more DRY by introducing SinlgePassTranslator as suggested
in TODO.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message