commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pascal Schumacher (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LANG-1295) ArrayUtils.toArray(T... items) has unsafe use of varargs
Date Sat, 21 Jan 2017 10:52:26 GMT

    [ https://issues.apache.org/jira/browse/LANG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832097#comment-15832097
] 

Pascal Schumacher edited comment on LANG-1295 at 1/21/17 10:51 AM:
-------------------------------------------------------------------

As I first step I have just removed the SafeVarargs annotation from the method.


was (Author: pascalschumacher):
As I first step I just removed the SafeVarargs annotation from the method.

> ArrayUtils.toArray(T... items) has unsafe use of varargs
> --------------------------------------------------------
>
>                 Key: LANG-1295
>                 URL: https://issues.apache.org/jira/browse/LANG-1295
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>    Affects Versions: 3.5
>            Reporter: Duncan Jones
>            Priority: Critical
>
> {{ArrayUtils.toArray(T... items)}} is marked as {{@SafeVarargs}}, but I suspect the use
of the varargs is unsafe.
> An example, drawn heavily from [this StackOverflow answer|http://stackoverflow.com/a/14252221/474189],
demonstrates this:
> {code:java}
> static <T> T[] arrayOfTwo(T a, T b) {
>     return ArrayUtils.toArray(a, b);
> }
> @Test
> public void testBadVarArgs() throws Exception {
>     @SuppressWarnings("unused") // Need to assign to trigger exception
>     String[] result = arrayOfTwo("foo", "bar");
> }
> {code}
> the above code throws an exception: {{java.lang.ClassCastException: [Ljava.lang.Object;
cannot be cast to [Ljava.lang.String;}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message