commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ric Emery (JIRA)" <j...@apache.org>
Subject [jira] [Created] (IMAGING-199) All tEXt chunks are not returned from PngImageParser.getMetadata
Date Mon, 19 Dec 2016 17:16:58 GMT
Ric Emery created IMAGING-199:
---------------------------------

             Summary: All tEXt chunks are not returned from PngImageParser.getMetadata
                 Key: IMAGING-199
                 URL: https://issues.apache.org/jira/browse/IMAGING-199
             Project: Commons Imaging
          Issue Type: Bug
          Components: Format: PNG
            Reporter: Ric Emery
            Priority: Minor


According to the PNG spec - Section 4.2.3 - Textual Information -

"Any number of text chunks can appear, and more than one with the same keyword is permissible.
"

Unfortunately the PngImageParser.getMetadata method only supports a single tEXt chunk.  The
problem is in the following line:

        final List<PngChunk> chunks = readChunks(byteSource, new ChunkType[] { ChunkType.tEXt,
ChunkType.zTXt, }, true);

True is being passed for returnAfterFirst. I believe that false should be passed instead.

I can submit a pull request if you agree.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message