commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duncan Jones (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-833) ToStringBuilder should use StringBuilder
Date Sun, 18 Dec 2016 16:18:58 GMT

    [ https://issues.apache.org/jira/browse/LANG-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15759047#comment-15759047
] 

Duncan Jones commented on LANG-833:
-----------------------------------

The documentation for {{ToStringBuilder}} makes no guarantees about thread-safety. Do we need
to preserve non-documented behaviour?

We could add another constructor that accepts a {{StringBuilder}}, then internally only use
a {{StringBuffer}} if the class is constructed with one.

> ToStringBuilder should use StringBuilder
> ----------------------------------------
>
>                 Key: LANG-833
>                 URL: https://issues.apache.org/jira/browse/LANG-833
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.1
>            Reporter: Shevek
>             Fix For: Patch Needed
>
>
> Rewriting as lang3 but still using StringBuffer (synchronized) looks like a missed opportunity.
Please use StringBuilder.
> Suggest audit for uses of StringBuffer in lang3 overall. No cause for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message