Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Wed, 9 Nov 2016 14:15:58 +0000 (UTC)
From: "Dominik Stadler (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.13019545.1478700865000.232809.1478700958581@Atlassian.JIRA>
In-Reply-To: <JIRA.13019545.1478700865000@Atlassian.JIRA>
References: <JIRA.13019545.1478700865000@Atlassian.JIRA> <JIRA.13019545.1478700865706@arcas>
Subject: [jira] [Updated] (LANG-1283) RecursiveToStringStyle does not handle
 nested Maps correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 09 Nov 2016 14:16:01 -0000


     [ https://issues.apache.org/jira/browse/LANG-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dominik Stadler updated LANG-1283:
----------------------------------
    Flags: Patch

> RecursiveToStringStyle does not handle nested Maps correctly
> ------------------------------------------------------------
>
>                 Key: LANG-1283
>                 URL: https://issues.apache.org/jira/browse/LANG-1283
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.builder.*
>    Affects Versions: 3.4
>            Reporter: Dominik Stadler
>         Attachments: RecursiveToStringTest.java
>
>
> When using {{RecursiveToStringStyle}} to include all member fields of all nested objects, it works for simple Maps, but as soon as I have Maps as values inside another Map, the contents is not included any more, but only a Object.toString() seems to be appended for the objects instead.
> A possible fix would be to add  the following to RecursiveToStringStyle, although there might be a better way to fix this:
> {code}
>         @Override
>         protected void appendDetail(StringBuffer buffer, String fieldName, Map<?, ?> map) {
>             appendClassName(buffer, map);
>             appendIdentityHashCode(buffer, map);
>             appendDetail(buffer, fieldName, map.entrySet());
>         }
> {code}
> See the attached unit-test for a reproducer.
> Please also note that {{RecursiveToStringStyleTest}} in commons-lang seems to mostly work on the DefaultStyle instead, see https://github.com/apache/commons-lang/blob/master/src/test/java/org/apache/commons/lang3/builder/RecursiveToStringStyleTest.java#L38, only one method, {{testPerson()}}, seems to actually do a real test here!


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)