Return-Path: <issues-return-57693-archive-asf-public=cust-asf.ponee.io@commons.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id A9EEE200BC2
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed,  2 Nov 2016 22:43:00 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id A8993160AF0; Wed,  2 Nov 2016 21:43:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 00832160AFB
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  2 Nov 2016 22:42:59 +0100 (CET)
Received: (qmail 96677 invoked by uid 500); 2 Nov 2016 21:42:59 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 96611 invoked by uid 99); 2 Nov 2016 21:42:59 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2016 21:42:59 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id E6ED02C1F56
	for <issues@commons.apache.org>; Wed,  2 Nov 2016 21:42:58 +0000 (UTC)
Date: Wed, 2 Nov 2016 21:42:58 +0000 (UTC)
From: "Mark Thomas (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12994644.1470245652000.165292.1478122978942@Atlassian.JIRA>
In-Reply-To: <JIRA.12994644.1470245652000@Atlassian.JIRA>
References: <JIRA.12994644.1470245652000@Atlassian.JIRA> <JIRA.12994644.1470245652051@arcas>
Subject: [jira] [Resolved] (DBCP-468) Hardcoded value false for
 fastFailValidation on constructor
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Wed, 02 Nov 2016 21:43:00 -0000


     [ https://issues.apache.org/jira/browse/DBCP-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Thomas resolved DBCP-468.
------------------------------
       Resolution: Fixed
    Fix Version/s: 2.2

Thanks for the report.

> Hardcoded value false for fastFailValidation on constructor
> -----------------------------------------------------------
>
>                 Key: DBCP-468
>                 URL: https://issues.apache.org/jira/browse/DBCP-468
>             Project: Commons Dbcp
>          Issue Type: Bug
>    Affects Versions: 2.2, 2.1.1
>            Reporter: Euclides M
>             Fix For: 2.2
>
>
> Debugging my code, i Found that fastFailValidation is always false because of this Constructor:
> {code:title=org.apache.commons.dbcp2.PoolableConnection|borderStyle=solid}
>     /**
>     *
>     * @param conn my underlying connection
>     * @param pool the pool to which I should return when closed
>     * @param jmxName JMX name
>     */
>    public PoolableConnection(Connection conn,
>            ObjectPool<PoolableConnection> pool, ObjectName jmxName) {
>        this(conn, pool, jmxName, null, false);
>    }
> {code}
> Notice that 4th and 5th params are for fastFailValidation. It will always be false. (and null for sql codes)
> My Pool definition (spring):
> {code:xml}
>  <bean id="dataSource" class="org.apache.commons.dbcp2.managed.BasicManagedDataSource" destroy-method="close">
>    <property name="transactionManager" ref="jbossTransactionManager"/>
>     <property name="driverClassName" value="xxx" />
>     <property name="url" value="xxx" />
>     <property name="username" value="xxx" />
>     <property name="password" value="xxx" />
>     <property name="initialSize" value="0" />
>     <property name="defaultAutoCommit" value="false" />
>     <property name="maxTotal" value="1" />
>     <property name="maxIdle" value="0" />
>     <property name="maxWaitMillis" value="5000" />
>     <property name="testOnBorrow" value="true" />
>     <property name="testOnReturn" value="false" />
>     <property name="fastFailValidation" value="true" />
>     <property name="validationQuery" value="select 1 go" />
>  </bean>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)