commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CSV-203) withNullString value is printed without quotes when QuoteMode.ALL is specified
Date Tue, 22 Nov 2016 19:19:58 GMT

    [ https://issues.apache.org/jira/browse/CSV-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687619#comment-15687619
] 

Benedikt Ritter commented on CSV-203:
-------------------------------------

Very nice wording "CommonsCsvIsSlightlyBroken" - makes me want to fix that right away for
you ;-)

Are you up for providing a patch?

> withNullString value is printed without quotes when QuoteMode.ALL is specified
> ------------------------------------------------------------------------------
>
>                 Key: CSV-203
>                 URL: https://issues.apache.org/jira/browse/CSV-203
>             Project: Commons CSV
>          Issue Type: Bug
>          Components: Printer
>    Affects Versions: 1.3, 1.4
>            Reporter: Richard Wheeldon
>              Labels: regression
>
> When setting QuoteMode.ALL is set we expect all values to be quoted, even those set as
a default. This works in Commons 1.2 but doesn't in 1.4.
> Consider the following program:
> {code}
> import org.apache.commons.csv.QuoteMode;
> import org.apache.commons.csv.CSVFormat;
> import org.apache.commons.csv.CSVPrinter;
> public class CommonsCsvIsSlightlyBroken {
>     
>     public static void main(String[] args) throws Exception {
>         CSVFormat format = CSVFormat.EXCEL
>             .withNullString("N/A")
>             .withIgnoreSurroundingSpaces(true)
>             .withQuoteMode(QuoteMode.ALL);
>         CSVPrinter printer = new CSVPrinter(System.out, format);
>         printer.printRecord(new Object[] { null, "Hello", null, "World" });
>     }
> }
> {code}
> For 1.2 we get quoted output:
> {code}
> richard@kichemaru:~/$ java -cp ~/.m2/repository/org/apache/commons/commons-csv/1.2/commons-csv-1.2.jar:.
CommonsCsvIsSlightlyBroken
> "N/A","Hello","N/A","World"
> {code}
> When run with 1.4 we get unquoted output for default fields:
> {code}
> richard@kichemaru:~/$ java -cp ~/.m2/repository/org/apache/commons/commons-csv/1.4/commons-csv-1.4.jar:.
CommonsCsvIsSlightlyBroken
> N/A,"Hello",N/A,"World"
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message