commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1274) StrSubstitutor should state its thread safety
Date Fri, 04 Nov 2016 17:34:58 GMT

    [ https://issues.apache.org/jira/browse/LANG-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637093#comment-15637093
] 

ASF GitHub Bot commented on LANG-1274:
--------------------------------------

GitHub user PascalSchumacher opened a pull request:

    https://github.com/apache/commons-lang/pull/207

    LANG-1274: StrSubstitutor should state its thread safety

    Add paragraph to class javadoc stating that StrSubstitutor is not thread safe.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PascalSchumacher/commons-lang StrSubstitutor_thread_safety_documenation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/207.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #207
    
----
commit 9fee75f1f39e48e714c85ea28b1d372afee5605b
Author: pascalschumacher <pascalschumacher@gmx.net>
Date:   2016-11-04T17:32:39Z

    LANG-1274: StrSubstitutor should state its thread safety
    
    Add paragraph to class javadoc stating that StrSubstitutor is not thread safe.

----


> StrSubstitutor should state its thread safety
> ---------------------------------------------
>
>                 Key: LANG-1274
>                 URL: https://issues.apache.org/jira/browse/LANG-1274
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.text.*
>    Affects Versions: 3.4
>            Reporter: david cogen
>            Priority: Trivial
>
> Because it doesn't document its thread safety, I am forced to conclude it is not thread
safe. I have no choice for my application but to create a derived class StrSubstitor_ThreadSafe
which wraps every method within a synchronized; that's tedious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message