commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "KeiichiFujino (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DBCP-462) Refactoring of PStmtKey and PoolingConnection
Date Mon, 07 Nov 2016 09:18:58 GMT

    [ https://issues.apache.org/jira/browse/DBCP-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643595#comment-15643595
] 

KeiichiFujino commented on DBCP-462:
------------------------------------

Thank you for the response. I confirmed it has been applied.
And I implemented the other methods to PoolingConnection in order to cache all of Prepared
and Callable Statement.
(see DBCP-474)

> Refactoring of PStmtKey and PoolingConnection
> ---------------------------------------------
>
>                 Key: DBCP-462
>                 URL: https://issues.apache.org/jira/browse/DBCP-462
>             Project: Commons Dbcp
>          Issue Type: Improvement
>    Affects Versions: 2.1.1
>            Reporter: KeiichiFujino
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: PStmtKey.txt, PoolingConnection.txt, TestPoolingConnection.java,
TesterConnection.txt, TesterPreparedStatement.txt
>
>
> In PoolingConnection, the following methods are not defined.
> -prepareStatement(String sql, int[] columnIndexes) 
> -prepareStatement(String sql, int resultSetType, int resultSetConcurrency, int resultSetHoldability)

> -prepareStatement(String sql, String[] columnNames) 
> -prepareCall(String sql, int resultSetType, int resultSetConcurrency, int resultSetHoldability)

> Therefore, when calling these methods, we can not cache statements.
> I had tried to implement these methods in PoolingConnection.
> However, because the code in the PoolingConnection#makeObject is a little complex,
> I thought that it is difficult to add new conditions.
> So, in order to more easily implement the Connection#prepareStatement that are not defined
in the PoolingConnection, 
> I did a refactoring for the PStmtKey and PoolingConnection.
> If these refactoring are accepted,I have a plan to implement the following methods to
PoolingConnection 
> in order to cache all of Prepared or Callable Statement.
> -prepareStatement(String sql, int[] columnIndexes) 
> -prepareStatement(String sql, int resultSetType, int resultSetConcurrency, int resultSetHoldability)

> -prepareStatement(String sql, String[] columnNames) 
> -prepareCall(String sql, int resultSetType, int resultSetConcurrency, int resultSetHoldability)




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message