commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yurelle <...@git.apache.org>
Subject [GitHub] commons-lang issue #219: LANG-341: Add number to byte array methods to org.a...
Date Sat, 26 Nov 2016 23:16:08 GMT
Github user yurelle commented on the issue:

    https://github.com/apache/commons-lang/pull/219
  
    I got a little carried away; this PR is 4,500 lines. I'm sure this is probably going to
take quite a while to validate and get accepted into the code base. I'm just glad I could
get the ball rolling. If someone could check on my big/little endian implementations, I'd
appreciate it. I can never keep those straight. I went off of these references:
    https://www.cs.umd.edu/class/sum2003/cmsc311/Notes/Data/endian.html
    https://en.wikipedia.org/wiki/Endianness
    https://en.wikipedia.org/wiki/Bit_numbering
    
    I'm not sure why it's saying that test coverage went down. As far as I can tell, I've
got tests for all my new functions.
    
    One thing to note: in all my new functions that had a pre-existing alternate implementation,
I added a chunk in the unit test to compare my results with the existing implementation. However,
I had some trouble getting proper data out of the pre-existing hexToPrimitive() functions.
The test code to do this validation is in the JUnit functions, but it's commented out. I'm
probably just not understanding the existing implementation properly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message