commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kinow <...@git.apache.org>
Subject [GitHub] commons-lang pull request #195: LANG-1160 StringUtils.abbreviate() to suppor...
Date Thu, 13 Oct 2016 09:59:44 GMT
GitHub user kinow opened a pull request:

    https://github.com/apache/commons-lang/pull/195

    LANG-1160 StringUtils.abbreviate() to support 'custom ellipses' parameter

    From [LANG-1160](https://issues.apache.org/jira/browse/LANG-1160).
    
    Before this pull request the code contained only two abbreviate methods. One abbreviate(String,
int) that would call the other one abbreviate(String, int, int) with a default value for one
of the int parameters.
    
    This pull request adds two other methods with the same name, but that receive a custom
abbreviation marker. The existing methods were update to call the new complete method with
a default abbreviation marker of "...", which guarantees backward compatibility (we are keeping
binary compatibility, and also feature backward compatibility).
    
    Tests were update, test coverage is the same as before. No issues found building the site
locally and from looking at CPD, PMD, FindBugs, CheckStyle and Surefire reports; all tests
passing locally, with additional two tests in this PR.
    
    Cheers
    Bruno

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kinow/commons-lang fix-LANG-1160

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #195
    
----
commit a7b552208acb7d4eb6d79bddb60cb358ae1ce5bd
Author: Bruno P. Kinoshita <kinow@apache.org>
Date:   2016-10-13T09:55:17Z

    LANG-1160 StringUtils.abbreviate() to support 'custom ellipses' parameter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message