commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Mole (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (COMPRESS-367) ZipArchiveInputStream.getNextZipEntry() should differentiate between "invalid entry encountered" and "no more entries"
Date Fri, 28 Oct 2016 12:13:59 GMT

     [ https://issues.apache.org/jira/browse/COMPRESS-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Mole updated COMPRESS-367:
----------------------------------
    Attachment: 0001-COMPRESS-367-Throw-ZipException-on-invalid-entry-wit.patch

Attached is fix, new test, and fix for existing test.

> ZipArchiveInputStream.getNextZipEntry() should differentiate between "invalid entry encountered"
and "no more entries"
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: COMPRESS-367
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-367
>             Project: Commons Compress
>          Issue Type: Bug
>          Components: Archivers
>    Affects Versions: 1.12
>            Reporter: Michael Mole
>            Priority: Minor
>             Fix For: 1.13
>
>         Attachments: 0001-COMPRESS-367-Throw-ZipException-on-invalid-entry-wit.patch
>
>
> ZipArchiveInputStream.getNextZipEntry() currently returns null if an invalid entry is
encountered.  Thus, it's not possible to differentiate between "no more entries" and "invalid
entry encountered" conditions.
> Instead, it should throw an exception if an invalid entry is encountered.
> I've created a test case and fix. I will submit a pull request shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message