commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kaloyan Spiridonov (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LOGGING-163) BufferedReader is not closed properly
Date Mon, 17 Oct 2016 14:32:58 GMT

     [ https://issues.apache.org/jira/browse/LOGGING-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kaloyan Spiridonov updated LOGGING-163:
---------------------------------------
    Description: 
In LogFactory class at line 552 there is BufferedReader that is not closed properly. For example
if rd.readLine(); throw an exception then the Reader will remain open.

 BufferedReader rd;
try {
    rd = new BufferedReader(new InputStreamReader(is, "UTF-8"));
 } catch (java.io.UnsupportedEncodingException e) {
     rd = new BufferedReader(new InputStreamReader(is));
}

String factoryClassName = rd.readLine();
rd.close();


In SimpleLog class at line 163 there is InputStream that is not closed properly. 

        InputStream in = getResourceAsStream("simplelog.properties");
        if(null != in) {
            try {
                simpleLogProps.load(in);
                in.close();
            } catch(java.io.IOException e) {
                // ignored
            }
        }

  was:
In LogFactory class at line 552 there is BufferedReader that is not closed properly. For example
if rd.readLine(); throw an exception then the Reader will remain open.

 BufferedReader rd;
try {
    rd = new BufferedReader(new InputStreamReader(is, "UTF-8"));
 } catch (java.io.UnsupportedEncodingException e) {
     rd = new BufferedReader(new InputStreamReader(is));
}

String factoryClassName = rd.readLine();
rd.close();


> BufferedReader is not closed properly
> -------------------------------------
>
>                 Key: LOGGING-163
>                 URL: https://issues.apache.org/jira/browse/LOGGING-163
>             Project: Commons Logging
>          Issue Type: Bug
>    Affects Versions: 1.1.1
>            Reporter: Kaloyan Spiridonov
>
> In LogFactory class at line 552 there is BufferedReader that is not closed properly.
For example if rd.readLine(); throw an exception then the Reader will remain open.
>  BufferedReader rd;
> try {
>     rd = new BufferedReader(new InputStreamReader(is, "UTF-8"));
>  } catch (java.io.UnsupportedEncodingException e) {
>      rd = new BufferedReader(new InputStreamReader(is));
> }
> String factoryClassName = rd.readLine();
> rd.close();
> In SimpleLog class at line 163 there is InputStream that is not closed properly. 
>         InputStream in = getResourceAsStream("simplelog.properties");
>         if(null != in) {
>             try {
>                 simpleLogProps.load(in);
>                 in.close();
>             } catch(java.io.IOException e) {
>                 // ignored
>             }
>         }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message