commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-1389) Runtime Improvement for getSubMatrix in Array2DRowRealMatrix
Date Mon, 10 Oct 2016 16:43:20 GMT

    [ https://issues.apache.org/jira/browse/MATH-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15562763#comment-15562763
] 

Gilles commented on MATH-1389:
------------------------------

Customizing the code with additional knowledge (data layout) is an obvious use of method override.
If the patch enhances performance in some use-case and has no drawback, it should be applied.


> Runtime Improvement for getSubMatrix in Array2DRowRealMatrix
> ------------------------------------------------------------
>
>                 Key: MATH-1389
>                 URL: https://issues.apache.org/jira/browse/MATH-1389
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Christoph Dibak
>            Priority: Trivial
>         Attachments: 0001-faster-getSubMatrix-for-Array2DRowRealMatrix.patch, MatrixBenchmark.java,
RuntimeTestGetSubMatrix.java
>
>
> Using System.arraycopy() for creating sub-matrices in the getSubMatrix() method of Array2DRowRealMatrix
improves the runtime.  Tested for a matrix with dimension 50x50, the execution time was 16
times faster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message