commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1268) Add methods for comparing numbers/compareables against each others to Validate
Date Mon, 31 Oct 2016 22:38:59 GMT

    [ https://issues.apache.org/jira/browse/LANG-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623654#comment-15623654
] 

ASF GitHub Bot commented on LANG-1268:
--------------------------------------

GitHub user PascalSchumacher opened a pull request:

    https://github.com/apache/commons-lang/pull/204

    LANG-1268: Add methods for comparing numbers/compareables against eac…

    …h others to Validate
    
    It's not a completely satisfying solution, because double `compareTo` is not 100% compatible
with the comparison performed by the Java language numerical comparison operators: https://www.tutorialspoint.com/java/lang/double_compareto.htm


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PascalSchumacher/commons-lang validate_add_compare

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #204
    
----
commit dae83c6c098813f342c7840b9d7039e7a016c393
Author: pascalschumacher <pascalschumacher@gmx.net>
Date:   2016-10-31T22:34:08Z

    LANG-1268: Add methods for comparing numbers/compareables against each others to Validate

----


> Add methods for comparing numbers/compareables against each others to Validate
> ------------------------------------------------------------------------------
>
>                 Key: LANG-1268
>                 URL: https://issues.apache.org/jira/browse/LANG-1268
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>            Reporter: Benedikt Ritter
>             Fix For: 3.6
>
>
> Follow up to LANG-1134. The methods for comparing numbers against each others have been
removed in  http://git-wip-us.apache.org/repos/asf/commons-lang/commit/09686fad
> Problems with the proposed APIs:
> - we should use lessThan instead of smaller
> - "object" suffix for methods taking object references as parameters
> - different vs. notEquals



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message