Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
From: chtompki <git@git.apache.org>
To: issues@commons.apache.org
Reply-To: issues@commons.apache.org
Message-ID: <git-pr-186-commons-lang@git.apache.org>
Subject: [GitHub] commons-lang pull request #186: LANG-1252: rename isNumber, isCreatable. Acc...
Content-Type: text/plain
Date: Sun, 11 Sep 2016 01:21:06 +0000 (UTC)
archived-at: Sun, 11 Sep 2016 01:21:09 -0000

GitHub user chtompki opened a pull request:

    https://github.com/apache/commons-lang/pull/186

    LANG-1252: rename isNumber, isCreatable. Accommodate for java 6 "+" handing.

    Associated with: https://issues.apache.org/jira/browse/LANG-1252
    
    @britter, do you have any thoughts on this. I think that it sufficiently covers the issue, but I wasn't sure about the mechanics about predicating functionality on java version. The main issue is that `new java.math.BigInteger("+2")` works for Java 1.7 and up, but not in Java 1.6. On the other hand `java.math.Float.valueOf("+2.0")` works on all versions of java. So I tried to accommodate for that in the `isCreatable` method.
    
    Based on your email about releases and my being slightly deadline driven person, I figured I'd try to put something reasonable together for the 3.5 release candidate. That said, if the diff on the PR doesn't look solid enough, I'm willing to work on the changes some more.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chtompki/commons-lang LANG-1252

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/186.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #186
    
----
commit c503d742f094dc2048b72c3f78f5e2e6070a44e1
Author: Rob Tompkins <chtompki@gmail.com>
Date:   2016-09-11T01:01:08Z

    LANG-1252: better naming and java 6 specifics around handling a leading +

commit 0a0a35f54f5e7ab2d10022d3ee244cbc876bdde2
Author: Rob Tompkins <chtompki@gmail.com>
Date:   2016-09-11T01:07:42Z

    LANG-1252: updates to package-info, adding name to pom.xml

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---