Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Mon, 26 Sep 2016 04:02:21 +0000 (UTC)
From: "Prateek Rungta (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.13007014.1474596367000.659798.1474862541819@Atlassian.JIRA>
In-Reply-To: <JIRA.13007014.1474596367000@Atlassian.JIRA>
References: <JIRA.13007014.1474596367000@Atlassian.JIRA> <JIRA.13007014.1474596367672@arcas>
Subject: [jira] [Commented] (CSV-197) CSVParser doesn't close the underlying
 handle after iteration
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 26 Sep 2016 04:02:23 -0000


    [ https://issues.apache.org/jira/browse/CSV-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15521968#comment-15521968 ] 

Prateek Rungta commented on CSV-197:
------------------------------------

Yep, that's what I did once I found the leak. I didn't initially, expecting an Iterable to close the underlying handle. That said, I don't know if it's any clearer than expecting users to maintain the lifecycle themselves. 

> CSVParser doesn't close the underlying handle after iteration
> -------------------------------------------------------------
>
>                 Key: CSV-197
>                 URL: https://issues.apache.org/jira/browse/CSV-197
>             Project: Commons CSV
>          Issue Type: Bug
>          Components: Parser
>            Reporter: Prateek Rungta
>            Priority: Minor
>             Fix For: Patch Needed, Discussion, 1.4.1
>
>
> The following code leaks file handles:
> {code}
> CSVParser parser = // setup parser
> for (CSVRecord rec: parser) {
> }
> // leak
> {code}
> I'd expect the underlying iterator to close() if it's finished iterating. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)