Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 65235200B8E for ; Sun, 11 Sep 2016 20:10:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 61F45160AB6; Sun, 11 Sep 2016 18:10:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AE83E160AC7 for ; Sun, 11 Sep 2016 20:10:21 +0200 (CEST) Received: (qmail 67969 invoked by uid 500); 11 Sep 2016 18:10:20 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 67850 invoked by uid 99); 11 Sep 2016 18:10:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Sep 2016 18:10:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7B1AB2C1B79 for ; Sun, 11 Sep 2016 18:10:20 +0000 (UTC) Date: Sun, 11 Sep 2016 18:10:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LANG-1263) Add possibility to retrieve the current JavaVersion MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 11 Sep 2016 18:10:22 -0000 [ https://issues.apache.org/jira/browse/LANG-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482167#comment-15482167 ] ASF GitHub Bot commented on LANG-1263: -------------------------------------- Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/187#discussion_r78299605 --- Diff: src/test/java/org/apache/commons/lang3/JavaVersionTest.java --- @@ -72,4 +73,28 @@ public void testToString() { assertEquals("1.2", JAVA_1_2.toString()); } + @Test + public void testCurrent() throws Exception { + if (SystemUtils.JAVA_SPECIFICATION_VERSION.equals("1.1")) { + assertEquals(JAVA_1_1, JavaVersion.CURRENT); + } else if (SystemUtils.JAVA_SPECIFICATION_VERSION.equals("1.2")) { + assertEquals(JAVA_1_2, JavaVersion.CURRENT); + } else if (SystemUtils.JAVA_SPECIFICATION_VERSION.equals("1.3")) { + assertEquals(JAVA_1_3, JavaVersion.CURRENT); + } else if (SystemUtils.JAVA_SPECIFICATION_VERSION.equals("1.4")) { + assertEquals(JAVA_1_4, JavaVersion.CURRENT); + } else if (SystemUtils.JAVA_SPECIFICATION_VERSION.equals("1.5")) { + assertEquals(JAVA_1_5, JavaVersion.CURRENT); + } else if (SystemUtils.JAVA_SPECIFICATION_VERSION.equals("1.6")) { + assertEquals(JAVA_1_6, JavaVersion.CURRENT); + } else if (SystemUtils.JAVA_SPECIFICATION_VERSION.equals("1.7")) { + assertEquals(JAVA_1_7, JavaVersion.CURRENT); + } else if (SystemUtils.JAVA_SPECIFICATION_VERSION.equals("1.8")) { + assertEquals(JAVA_1_8, JavaVersion.CURRENT); + } else if (SystemUtils.JAVA_SPECIFICATION_VERSION.equals("9.0.0")) { --- End diff -- Not sure if this is correct. Shouldn't it be something like `9.` if I understand http://openjdk.java.net/jeps/223 correctly? > Add possibility to retrieve the current JavaVersion > --------------------------------------------------- > > Key: LANG-1263 > URL: https://issues.apache.org/jira/browse/LANG-1263 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* > Reporter: Benedikt Ritter > Assignee: Benedikt Ritter > Fix For: 3.5 > > > Currently one has to iterate over all JavaVersion enum values and compare them to the value of java.specification.version in order to get the current JavaVersion enum value. > Provide a convenient method for this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)