Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Sun, 11 Sep 2016 13:42:20 +0000 (UTC)
From: "Benedikt Ritter (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12827841.1430951310000.541817.1473601340734@Atlassian.JIRA>
In-Reply-To: <JIRA.12827841.1430951310000@Atlassian.JIRA>
References: <JIRA.12827841.1430951310000@Atlassian.JIRA> <JIRA.12827841.1430951310176@arcas>
Subject: [jira] [Commented] (LANG-1134) New methods for lang3.Validate
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 11 Sep 2016 13:42:22 -0000


    [ https://issues.apache.org/jira/browse/LANG-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15481775#comment-15481775 ] 

Benedikt Ritter commented on LANG-1134:
---------------------------------------

I don't think the design is ready to be shipped with 3.5. `differentObj` is a bad method name. If could be `differentObject`. Furthermore I don't understand why we need to use a `Comparator` to decide whether the objects a different from one another. I would this to be tested using `Object.equals`.

> New methods for lang3.Validate
> ------------------------------
>
>                 Key: LANG-1134
>                 URL: https://issues.apache.org/jira/browse/LANG-1134
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.4
>            Reporter: Stardust
>            Assignee: Charles Honton
>            Priority: Minor
>             Fix For: 3.5
>
>
> These are suggestions for new methods for the Validate class.
> h1. Floating point values
> h2. notNaN(value)
> Throws an exception if value != value .
> {code}double value;
> value = Double.NaN;
> Validate.notNaN(value);    // Throws exception
> value = 1.0;
> Validate.notNaN(value);    // Validates
> value = Double.POSITIVE_INFINITY;
> Validate.notNaN(value);    // Validates{code}
> h2. finite(value)
> Validates that the argument contains a numeric value (not NaN or infinite).
> {code}double value;
> value = Double.NaN;
> Validate.finite(value);    // Throws exception
> value = Double.POSITIVE_INFINITY;
> Validate.finite(value);    // Throws exception
> value = 1.0;
> Validate.finite(value);    // Validates{code}
> h1. Integers and floats
> The following methods are overloaded to accept both integers and floating point values.
> h2. greater(reference, value), greaterOrEqual(reference, value)
> Ensures the argument is greater than (or equal to) a given value.
> {code}double value;
> value = 0.0;
> Validate.greater(0.0, value);    // Throws exception
> Validate.greaterOrEqual(0.0, value); // Validates
> value = Double.POSITIVE_INFINITY;
> Validate.greater(0.0, value);    // Validates
> value = Double.NaN;
> Validate.greater(0.0, value);    // Throws exception{code}
> h2. smaller(reference, value), smallerOrEqual(reference, value)
> Ensures the argument is smaller than (or equal to) a given value. Does the opposite of greater(), see example above.
> h2. different(reference, value)
> Ensures the argument is not equal to a given value. A typical use case would be to accept only non-zero values.
> {code}double value;
> value = 0.0;
> Validate.different(0.0, value);    // Throws exception
> Validate.different(1.0, value);    // Validates
> value = Double.NaN;
> Validate.different(0.0, value);    // Validates{code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)