commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (IO-515) Allow Specifying Initial Buffer Size of DeferredFileOutputStream
Date Wed, 28 Sep 2016 17:09:20 GMT


ASF GitHub Bot commented on IO-515:

Github user brettlounsbury closed the pull request at:

> Allow Specifying Initial Buffer Size of DeferredFileOutputStream
> ----------------------------------------------------------------
>                 Key: IO-515
>                 URL:
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Streams/Writers
>            Reporter: Brett Lounsbury
>            Assignee: Gary Gregory
>             Fix For: 2.6
> Right now the DeferredFileOutputStream uses a ByteArrayOputStream for its in memory buffer.
 It simply does new ByteArrayOutputStream() which initializes the ByteArrayOutputStream's
internal buffer to 32B.  In the case of large threshold values for in-memory buffering this
can become very inefficient (Requiring 15 array doubling operations to grow to 1MB and producing
an extra 1MB of garbage along the way).
> By allowing the user to specify the initial buffer size we allow them to tune how many
times the array will need to double to something that meets their application's needs.
> In our testing we had an application that used a DeferredFileOutputStream to capture
incoming data.  Once that data was fully captured it did some fairly CPU intensive processing
of the data.  The ByteArrayOutputStream used by DeferredFileOutputStream was using 60% of
our host's CPU simply on array copying.

This message was sent by Atlassian JIRA

View raw message