commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prateek Rungta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CSV-197) CSVParser doesn't close the underlying handle after iteration
Date Mon, 26 Sep 2016 04:02:21 GMT

    [ https://issues.apache.org/jira/browse/CSV-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15521968#comment-15521968
] 

Prateek Rungta commented on CSV-197:
------------------------------------

Yep, that's what I did once I found the leak. I didn't initially, expecting an Iterable to
close the underlying handle. That said, I don't know if it's any clearer than expecting users
to maintain the lifecycle themselves. 

> CSVParser doesn't close the underlying handle after iteration
> -------------------------------------------------------------
>
>                 Key: CSV-197
>                 URL: https://issues.apache.org/jira/browse/CSV-197
>             Project: Commons CSV
>          Issue Type: Bug
>          Components: Parser
>            Reporter: Prateek Rungta
>            Priority: Minor
>             Fix For: Patch Needed, Discussion, 1.4.1
>
>
> The following code leaks file handles:
> {code}
> CSVParser parser = // setup parser
> for (CSVRecord rec: parser) {
> }
> // leak
> {code}
> I'd expect the underlying iterator to close() if it's finished iterating. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message