commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Viktoria Dlugopolskaya (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NET-477) TFTP sendFile retry broken
Date Fri, 09 Sep 2016 10:09:20 GMT

    [ https://issues.apache.org/jira/browse/NET-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15476713#comment-15476713
] 

Viktoria Dlugopolskaya commented on NET-477:
--------------------------------------------

I have the same problem with receiveFile() method.
When TFTP-server is not running and timeout is more than 1, receiveFile() method doesn't throw
an error, it returns empty file.

> TFTP sendFile retry broken
> --------------------------
>
>                 Key: NET-477
>                 URL: https://issues.apache.org/jira/browse/NET-477
>             Project: Commons Net
>          Issue Type: Bug
>          Components: TFTP
>    Affects Versions: 3.1, 3.2
>         Environment: Linux **** 3.2.0-29-generic #46-Ubuntu SMP Fri Jul 27 17:03:23 UTC
2012 x86_64 x86_64 x86_64 GNU/Linux
> java version "1.6.0_26"
> Java(TM) SE Runtime Environment (build 1.6.0_26-b03)
> Java HotSpot(TM) 64-Bit Server VM (build 20.1-b02, mixed mode)
>            Reporter: John Walton
>
> TFTPClient.java sendFile() method does not retry after initial timeout.
> Between revisons 1088720 & 1229692 the 'continue' statements were changed to 'continue
_sendPacket'. After the initial timeout of bufferedReceive() these cause the control to flow
to the outer loop and never retry. If the control did flow accordingly, the retry would loop
indefinitely since the timeouts variable is reset to zero each time as well.
> I am using a workaround by calling bufferedSend(sent) just before continue, in place
of the 'continue _sendPacket' statement.
> It looks as if similar logic was applied to the receiveFile() method as well.
> Revision:1229692
> Time:01/10/2012 01:14 PM
> Author:sebb
> Path:http://svn.apache.org/repos/asf/commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPClient.java
> Message:NET-410 Apache Commons TFTP does not handle RFC 783 retransmits



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message