Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 60B68200B85 for ; Wed, 31 Aug 2016 12:42:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5F47D160A8C; Wed, 31 Aug 2016 10:42:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D3E4A160AB4 for ; Wed, 31 Aug 2016 12:42:21 +0200 (CEST) Received: (qmail 78601 invoked by uid 500); 31 Aug 2016 10:42:20 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 78526 invoked by uid 99); 31 Aug 2016 10:42:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Aug 2016 10:42:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 97C332C1B7B for ; Wed, 31 Aug 2016 10:42:20 +0000 (UTC) Date: Wed, 31 Aug 2016 10:42:20 +0000 (UTC) From: "Henri Biestro (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (JEXL-213) rename JexlBuilder.loader(Charset arg) to JexlBuilder.charset(Charset arg) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 31 Aug 2016 10:42:22 -0000 [ https://issues.apache.org/jira/browse/JEXL-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro resolved JEXL-213. -------------------------------- Resolution: Fixed Assignee: Henri Biestro Fix Version/s: 3.1 Add charset(Charset arg) to JexlBuilder, deprecated loader(Charset...) which is indeed a mistake (but public API). src/main/java/org/apache/commons/jexl3/JexlBuilder.java Committed revision 1758578. > rename JexlBuilder.loader(Charset arg) to JexlBuilder.charset(Charset arg) > -------------------------------------------------------------------------- > > Key: JEXL-213 > URL: https://issues.apache.org/jira/browse/JEXL-213 > Project: Commons JEXL > Issue Type: Bug > Affects Versions: 3.0 > Reporter: Dmitri Blinov > Assignee: Henri Biestro > Priority: Minor > Fix For: 3.1 > > > There seems to be a copy-paste bug in method in {{JexlBuilder}} class > {code} > public JexlBuilder loader(Charset arg) { > this.charset = arg; > return this; > } > {code} > obviously the method should be named {{charset}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)