commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Tompkins (JIRA)" <>
Subject [jira] [Commented] (LANG-1252) NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently
Date Thu, 11 Aug 2016 14:33:21 GMT


Rob Tompkins commented on LANG-1252:

Regarding LANG-1038, {{NumberUtils.isNumber("-2")}} returns {{true}}. However, {{NumberUtils.isNumber("-2")}}
returns {{false}}. Further the following throw exceptions:
whereas the following succeed,

_*Note.*_ Benedikt suggested that {{NumberUtils.parseNumber(str)}} should not throw a {{NumberFormatException}}
and return a valid {{java.lang.Number}} if and only if {{NumberUtils.isParsable(str)}} returns
true for the same {{str}}. This seems to not be the case as:
NumberUtils.isParsable("+2"); // false
NumberUtils.parseNumber("+2"); // the value 2

This may be because in Java 6 only Float and Double return with a Valid number without exception.

> NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently
> ------------------------------------------------------------------------
>                 Key: LANG-1252
>                 URL:
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.math.*
>    Affects Versions: 3.4
>            Reporter: Rob Tompkins
>             Fix For: Discussion
> In considering the issues LANG-1060, LANG-1040, LANG-1038, and LANG-992, it seems that
there are times when {{NumberUtils.isNumber}} resolves to {{false}} while {{NumberUtils.createNumber}},
given the same input, does not throw an exception, returning a valid {{java.lang.Number}}.
This inconsistency should be resolved either by making {{isNumber}} more lenient or {{createNumber}}
more stringent.

This message was sent by Atlassian JIRA

View raw message