commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Vandahl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCS-165) BlockDiskCache partial remove / group remove doesn't work
Date Sun, 07 Aug 2016 09:45:20 GMT

    [ https://issues.apache.org/jira/browse/JCS-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410884#comment-15410884
] 

Thomas Vandahl commented on JCS-165:
------------------------------------

Wiktor, I really appreciate your contributions. However I kindly would like to ask for a little
bit more care for the details. The tests obviously were copied from IndexedDiskCache and still
contained references to the wrong disk path. Also please consider organizing the imports before
submitting the patch. Can we agree on this in the future? It would make it much easier (and
faster) to apply your patches!

> BlockDiskCache partial remove / group remove doesn't work
> ---------------------------------------------------------
>
>                 Key: JCS-165
>                 URL: https://issues.apache.org/jira/browse/JCS-165
>             Project: Commons JCS
>          Issue Type: Bug
>            Reporter: Wiktor N
>            Assignee: Thomas Vandahl
>         Attachments: BlockDiskCache_remove_patch.diff, BlockDiskCache_remove_testcases.diff
>
>
> BlockDiskCache implementation improperly handles removal using prefixes and groups.
> I'm attaching test cases (mostly - copy&paste from IndexedDiskCache for testing of
removals) and patch (mostly - copy&paste from IndexedCache).
> I tried to extract that to super-class methods, but in case of tests - that would require
opening API in AbstractDiskCache (most of the methods used in tests are protected), and in
case of fix - that would probably need to also abstract the locking mechanism.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message