commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1110) Implement HashSetvBitSetTest using JMH
Date Sat, 13 Aug 2016 00:37:20 GMT

    [ https://issues.apache.org/jira/browse/LANG-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419731#comment-15419731
] 

ASF GitHub Bot commented on LANG-1110:
--------------------------------------

GitHub user C0rWin opened a pull request:

    https://github.com/apache/commons-lang/pull/182

    Add maven dependency for JMH framework.

    In order to provide patch for LANG-1110, required dependcy on JMH lib.
    Current commit add benchmark profile and ability to run JMH based benchmark by
    executing "mvn test -P benchmark" command, moreover it's also possible to
    specify exact benchmark name by running "mvn test -P benchmark
    -Dbenchmark=benchmark.full.class.name".

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/C0rWin/commons-lang LANG-1256

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #182
    
----
commit 9f4c0ec4197331687e410aca492d4071eded2462
Author: Artem Barger <artem@bargr.net>
Date:   2016-08-13T00:33:08Z

    Add maven dependency for JMH framework.
    
    In order to provide patch for LANG-1110, required dependcy on JMH lib.
    Current commit add benchmark profile and ability to run JMH based benchmark by
    executing "mvn test -P benchmark" command, moreover it's also possible to
    specify exact benchmark name by running "mvn test -P benchmark
    -Dbenchmark=benchmark.full.class.name".

----


> Implement HashSetvBitSetTest using JMH
> --------------------------------------
>
>                 Key: LANG-1110
>                 URL: https://issues.apache.org/jira/browse/LANG-1110
>             Project: Commons Lang
>          Issue Type: Test
>          Components: lang.*
>            Reporter: Benedikt Ritter
>             Fix For: Patch Needed, 3.5
>
>
> HashSetvBitSetTest currently writes to Std out, which is bad practice for unit tests.
Since HashSetvBitSetTest is really a performance test and not a unit test, we should reimplement
it using OpenJMH. The results could then be published on our website.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message